Petr Horáček has posted comments on this change. Change subject: ovs: edit bond mode ......................................................................
Patch Set 10: Verified+1 (5 comments) Passed network/*test.py, functional tests (BondWithManyVlans|AddManyVlans|TwiceAdd) and manual testing (add/edit/remove bond options) https://gerrit.ovirt.org/#/c/58437/6/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: PS6, Line 216: miimon = parsed_options.get('miimon') : : bond_mode = 'active- > I refer to the defaults set in lines 210-211 Done PS6, Line 220: = 'off' > Sorry, still do not get it. I don't know it if makes any sence. For fallback mode, there is special database entry... We should ask someone from OVS. However, bond_mode is 'active-backup' by default. If we set lacp='on' it does nothing to bond_mode entry. So we are just explicitly showing defaults. PS6, Line 223: lacp = 'off' : elif mode in ('4', bonding.BONDING_MODES_NUMBER_TO_NAME['4']): : lacp = 'active' > Ok, then a TODO may be in order here. Done Line 223: lacp = 'off' Line 224: elif mode in ('4', bonding.BONDING_MODES_NUMBER_TO_NAME['4']): Line 225: lacp = 'active' Line 226: else: Line 227: # TODO: Validation should be moved to validator.py as soon as > If you can concentrate each 'attribute' processing together it will be nice Done Line 228: # we implement bond options canonicalization. Line 229: raise ne.ConfigNetworkError( Line 230: ne.ERR_BAD_PARAMS, Line 231: 'Mode {} is not available for OVS bondings'.format(mode)) https://gerrit.ovirt.org/#/c/58437/9/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: PS9, Line 228: # we implement bond options canonicalization. : raise ne.ConfigNetworkError( : ne.ERR_BAD_PARAMS, : 'Mode {} is not available for OVS bondings'.format(mode)) : commands.append(self._ovsdb.set_p > if - else seems more appropriate. Done -- To view, visit https://gerrit.ovirt.org/58437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
