Yaniv Bronhaim has posted comments on this change.

Change subject: Adding threads limitation to misc.tmap
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/miscTests.py
Line 184:     def testLimit(self):
Line 185:         def dummy(arg):
Line 186:             return arg
Line 187:         data = frozenset([1, 2, 3, 4, 5])
Line 188:         ret = frozenset(misc.tmap(dummy, data, 2))
The use of a frozenset instead of set means that the set values won't be 
changed during the code .. maybe you meant why do i need set at for.. i 
supposed to use a list or a tuple to verify that the values returned with the 
same order
Line 189:         self.assertEquals(data, ret)
Line 190: 
Line 191:     def testErrMethod(self):
Line 192:         exceptionStr = ("It's time to kick ass and chew bubble gum... 
" +


--
To view, visit http://gerrit.ovirt.org/8858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07845bfd78b9215e8994ac2ebe46a7ff78c85625
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to