Yaniv Bronhaim has posted comments on this change. Change subject: Adding threads limitation to misc.tmap ......................................................................
Patch Set 8: This changes the return value of itmap, with your suggestion itmap returns (index,val). I'm not sure if we want this kind of change.. only fileSD calls to itmap and I can modify it if this change sounds right. But then the use in itmap will look weird (itmap(...).next()[1] :/) Do you think it helps? or just redundant because nobody calls to tmap? As part of infra team, I'm not sure if to keep unused functions just to have more infrastructure is the right thing to do. In my opinion, I prefer to remove tmap because of its useless. If you initiate multiply threads with same implementation, you don't really care about the order.. -- To view, visit http://gerrit.ovirt.org/8858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07845bfd78b9215e8994ac2ebe46a7ff78c85625 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
