Irit Goihman has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/59306/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-06-14 15:00:54 +0300 Line 4: Commit: Irit Goihman <igoih...@redhat.com> Line 5: CommitDate: 2016-06-19 14:58:42 +0300 Line 6: Line 7: tox: skip code style validation if required tox version isn't > I know I suggested it :) but still - "fail make process if required tox ver Done Line 8: installed. Line 9: Line 10: Over RHEL 7.2 yum contains only tox-1.4.2 which doesn't fit to vdsm Line 11: requirements. https://gerrit.ovirt.org/#/c/59306/6/Makefile.am File Makefile.am: Line 81: Line 82: .PHONY: gitignore Line 83: gitignore: Line 84: @echo "Checking that .in files are ignored..." Line 85: @if test -f .gitignore; then \ > what if tox is not installed at all ? Done Line 86: for i in `git ls-files \*.in`; do \ Line 87: if ! grep -q -x $${i%%.in} .gitignore; then \ Line 88: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \ Line 89: done; \ Line 84: @echo "Checking that .in files are ignored..." Line 85: @if test -f .gitignore; then \ Line 86: for i in `git ls-files \*.in`; do \ Line 87: if ! grep -q -x $${i%%.in} .gitignore; then \ Line 88: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \ > you can use TOX_VERSION in the print as well Done Line 89: done; \ Line 90: fi; Line 91: Line 92: .PHONY: abs_imports -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
