Yaniv Bronhaim has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 81: done; Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85: if [ -x "$(TOX)" ]; then \ > -n was good enough - we detect TOX in configure, and if it is not installed do we? oh, missed that. Line 86: if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ Line 87: then \ Line 88: tox -- pyflakes ; \ Line 89: else \ Line 87: then \ Line 88: tox -- pyflakes ; \ Line 89: else \ Line 90: echo "Warning: skipping check since tox is too old \ Line 91: please install tox $(TOX_MIN_VERSION) or later."; \ > I'm fine with that, we will need to do this anyway since development tools Irit, keep the exit here, and the evironment env flag to disable style check run, and in separate patch remove the make check from the spec with a comment that we miss many tools to run our uts in the build systems, such as tox. Nir might be able to elaborate more Line 92: fi \ Line 93: else \ Line 94: echo "Warning: tox is not installed, skipping check"; \ Line 95: fi -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
