Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/59234/4/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 514: else: Line 515: response_log = "failed (error %s)" % (error.code,) Line 516: else: Line 517: response_log = "without response" Line 518: self.log.info("RPC call %s %s in %.2f seconds", > So lets do this in the previous patch that added the info logs. Piotr didn't protest, so done. Line 519: req.method, response_log, monotonic_time() - start_time) Line 520: if response is not None: Line 521: ctx.requestDone(response) Line 522: -- To view, visit https://gerrit.ovirt.org/59234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
