Nir Soffer has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py File lib/vdsm/rpc/bindingxmlrpc.py: Line 1209: start_time = utils.monotonic_time() Line 1210: try: Line 1211: logLevel = logging.DEBUG Line 1212: suppress_args = f.__name__ in ('fenceNode',) Line 1213: res = {} rest should be created before the try, since you are using it in finally. Line 1214: Line 1215: # TODO: This password protection code is fragile and ugly. Password Line 1216: # protection should be done in the wrapped methods, and logging Line 1217: # shold be done in the next layers, similar to storage logs. -- To view, visit https://gerrit.ovirt.org/59234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
