ShaoHe Feng has posted comments on this change.
Change subject: Change in error message format
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/gluster/exception.py
Line 50
Line 51
Line 52
Line 53
Line 54
how about leave return code:?
return '%s\n %s%s%s%sreturn code: %s' % \
(self.message,
'error: ' if (self.out or self.err) else '',
('\n'.join(self.out) + '\n') if self.out else '',
('\n'.join(self.err) + '\n') if self.err else '',
'\n' if not (self.out or self.err) else '',
self.rc)
Line 56: s = self.message
Line 57: if m:
Line 58: s += '\nerror: ' + m
Line 59: if self.rc:
Line 60: s += '\nreturn code: %s' % self.rc
I think, rc should not be None. it can indicate the kind of error.
why must remove “error:”. I think just leave the "error:" is OK, if both out
and err are empty.
Line 61:
Line 62: return s
Line 63:
Line 64: def response(self):
--
To view, visit http://gerrit.ovirt.org/8689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb948bb212ae866600aabad2190ff52f2cbc05bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
