Bala.FA has posted comments on this change. Change subject: Change in error message format ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/gluster/exception.py Line 56: s = self.message Line 57: if m: Line 58: s += '\nerror: ' + m Line 59: if self.rc: Line 60: s += '\nreturn code: %s' % self.rc As its base class, some of inherited class doesn't use rc and/or out and some class does. To make it generic, default value of rc, out and err shows 'success' illusion in messages at engine side. This fix just makes error message clear. 'return code: 0' or 'error:' doesn't make clarity to the user. Line 61: Line 62: return s Line 63: Line 64: def response(self): -- To view, visit http://gerrit.ovirt.org/8689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb948bb212ae866600aabad2190ff52f2cbc05bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
