Milan Zamazal has posted comments on this change. Change subject: migration: downtime: add tunable for back compat ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Thanks. https://gerrit.ovirt.org/#/c/59467/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 453: else: Line 454: self._wait = (delay_per_gib * max(memSize, 2048) + 1023) / 1024 Line 455: Line 456: # do not materialize, keep as generator expression Line 457: self._downtimes = exponential_downtime(self._downtime, self._steps) > we have both styles and no rule, but here I think the local variable is bet I think not retrieving the same information twice is a universal rule. :-) Line 458: Line 459: if use_qemu_iterations: Line 460: # we need the first value to support set_initial_downtime Line 461: self._initial_downtime = next(self._downtimes) -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
