Martin Polednik has posted comments on this change. Change subject: migration: downtime: add tunable for back compat ......................................................................
Patch Set 8: (1 comment) I think the code is fine. I'd like to take some more time to properly understand the change before giving +1. https://gerrit.ovirt.org/#/c/59467/8/vdsm/virt/migration.py File vdsm/virt/migration.py: PS8, Line 578: if self._use_qemu_iterations: I'd prefer seeing something resembling if self.downtime_thread.running() Not a big deal and possibly slightly controversial/impossible, judgement is yours. -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
