Nir Soffer has posted comments on this change. Change subject: schema: customizable hook name ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59251/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 4228: for the bridge device should be turned on Line 4229: name: stp Line 4230: type: string Line 4231: Line 4232: - defaultvalue: no-default > We need the keep to know that it is optional. If we add additional key we m This is bad, we will have to improve this. The fact that an option is required or optional is critical, having a default value in the schema is not needed at all. Not related to this patch of course, just make it harder to understand the changes. Line 4233: description: A map containing information about the Line 4234: bridge specific options. Line 4235: name: opts Line 4236: type: *StringMap -- To view, visit https://gerrit.ovirt.org/59251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb20039ef1d3bba32518dd23e6b30506cb77e0ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
