Piotr Kliczewski has posted comments on this change. Change subject: schema: customizable hook name ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/59251/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 7: type: enum Line 8: values: Line 9: 0: Auto numa balancing is not active Line 10: 1: Auto numa balancing is active Line 11: 2: Can't get the status(maybe not support in this kernel > Maybe create AutoNumaBalanchingStatusLegacy enum with the numbers, change t In the storage api is even worse because there is numeric and string based in use at the same time. Line 12: version) Line 13: Line 14: BalloonInfo: &BalloonInfo Line 15: added: '3.1' Line 1389: description: A mapping of hook script information Line 1390: name: HookScriptAdditional Line 1391: properties: Line 1392: - description: A key for hook script information Line 1393: name: custom_name > Maybe any_string? We need some string that would tell us that here we may have anything. any_string should be as good as custom_name. Line 1394: type: *HookScriptInfo Line 1395: type: object Line 1396: Line 1397: HookScriptInfoMap: &HookScriptInfoMap -- To view, visit https://gerrit.ovirt.org/59251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb20039ef1d3bba32518dd23e6b30506cb77e0ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
