Nir Soffer has posted comments on this change. Change subject: Kill and report asyncProc if fails on first write to stdin ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51763/8/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 745: finally: Line 746: runnable.stop() Line 747: Line 748: Line 749: def async_terminate(proc): Why async? This procedure should be good for any Popen/CPopen instance. We can call this terminate(), compared with the context manager terminating(). If we want to make it clear that this does not wait for the process, we can use terminate_nowait() (like Queue.get_nowait, Queue.put_nowait). Line 750: try: Line 751: if proc.poll() is None: Line 752: logging.debug('Terminating process pid=%d' % proc.pid) Line 753: proc.kill() -- To view, visit https://gerrit.ovirt.org/51763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
