Yaniv Bronhaim has posted comments on this change. Change subject: Kill and report asyncProc if fails on first write to stdin ......................................................................
Patch Set 9: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/51763/9/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 745: finally: Line 746: runnable.stop() Line 747: Line 748: Line 749: def terminating_nowait(proc): > Why terminating_nowait and not terminate_nowait? but its the same function that just doesn't block .. i think its more clear that way. Line 750: try: Line 751: if proc.poll() is None: Line 752: logging.debug('Terminating process pid=%d' % proc.pid) Line 753: proc.kill() -- To view, visit https://gerrit.ovirt.org/51763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
