Francesco Romani has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice ......................................................................
Patch Set 6: Code-Review-1 (1 comment) I'd like to try NOT to have this facade class. https://gerrit.ovirt.org/#/c/57963/6/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS6, Line 31: HostDevice I'd love to get rid of this facade. If the client code needs a generic HostDevice (e.g. does not care if it is PciDevice, UsbDevice, ScsiDevice), we could have a factory function instead. This class does mostly delegation, the only not-trivial thing seems to be update_device_info. -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
