Milan Zamazal has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 301: # way of reconstructing the udev name we use as unique id. Line 302: Line 303: Line 304: class HostDevice(core.Base): Line 305: __slots__ = ('_device',) Shouldn't this be removed? Line 306: Line 307: _DEVICE_MAPPING = { Line 308: 'pci': PciDevice, Line 309: 'usb_device': UsbDevice, -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
