Nir Soffer has submitted this change and it was merged. Change subject: build: Make sure run_tests*.sh scripts are executable ......................................................................
build: Make sure run_tests*.sh scripts are executable Generated script tests/run_tests_local.sh is not executable after `make clean; make' is run. This bug was introduced by commit 6e6f89b7, but there is probably nothing wrong with that commit, it just introduces removal of some files including run_tests_local.sh. The problem is tests/run_tests*.sh files are not set as executable if they are recreated any time later. This patch tries to solve the problem by making the following changes: - tests/run_tests*.sh are no longer handled in configure.ac. They are not config files and such a use of AC_OUTPUT is obsolete anyway. - New tests/Makefile.am rule is introduced ensuring generated run_tests*.sh files are set as executable. - top_srcdir substitution is added to Makefile.subs to make the inserted relative paths in the generated files always correct. - run_tests_local.sh is moved to *_SCRIPTS target in tests/Makefile.am. There may be other solutions of the problem but whatever solution is chosen, it should be checked that tests/run_tests*.sh files are executable and the paths inside the generated files are right in all the following situations: - After running ./autogen.sh + make in a fresh git directory. - After `rm tests/run_tests*.sh; make'. - After `(cd tests; rm run_tests*.sh; make)'. Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Signed-off-by: Milan Zamazal <mzama...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/55949 Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> Continuous-Integration: Jenkins CI Reviewed-by: Tomas Golembiovsky <tgole...@redhat.com> Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M build-aux/Makefile.subs M configure.ac M tests/Makefile.am 3 files changed, 9 insertions(+), 11 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomas Golembiovsky: Looks good to me, but someone else must approve Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/55949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
