Nir Soffer has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/55949/7//COMMIT_MSG Commit Message: Line 19: not config files and such a use of AC_OUTPUT is obsolete anyway. Line 20: - New Makefile.subs rule is introduced ensuring generated *.sh files are Line 21: set as executable. It applies to all generated *.sh files in Vdsm Line 22: source directory but that shouldn't be a problem as those files are Line 23: executable shell scripts anyway. Needs update, we don't have magic rules now. Line 24: - run_tests_local.sh is moved to *_SCRIPTS target in tests/Makefile.am. Line 25: Line 26: There may be other solutions of the problem but whatever solution is Line 27: chosen, it should be checked that tests/run_tests*.sh files are https://gerrit.ovirt.org/#/c/55949/7/tests/Makefile.am File tests/Makefile.am: Line 389: fi Line 390: Line 391: run_%.sh: run_%.sh.in Line 392: @echo " SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@ Line 393: chmod a+x "$@" Nice! -- To view, visit https://gerrit.ovirt.org/55949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
