Nir Soffer has posted comments on this change.

Change subject: qemuimg: Use --output json for 'check' and 'info'
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59649/3/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 65: @expandPermutations
Line 66: class InfoTests(TestCaseBase):
Line 67:     CLUSTER_SIZE = 65536
Line 68: 
Line 69:     def _data(self):
> Renamed to _fake_info.  It's not output.  It's a data representation of the
Sounds good.
Line 70:         return {
Line 71:             "virtual-size": 1048576,
Line 72:             "filename": "leaf.img",
Line 73:             "cluster-size": self.CLUSTER_SIZE,


-- 
To view, visit https://gerrit.ovirt.org/59649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to