Adam Litke has posted comments on this change.

Change subject: qemuimg: Use --output json for 'check' and 'info'
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/59649/5/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 35
Line 36
Line 37
Line 38
Line 39
> err must be "" now.
Done


Line 237
Line 238
Line 239
Line 240
Line 241
> err should be "" now.
Done


Line 39: def fake_json_call(data, cmd, **kw):
Line 40:     return 0, json.dumps(data), []
Line 41: 
Line 42: 
Line 43: class CommandTests(TestCaseBase):
> Bad rebase - this class is not use now.
Done
Line 44: 
Line 45:     def supported(self, command, result):
Line 46:         def check(arg):
Line 47:             self.assertEqual(command, arg)


-- 
To view, visit https://gerrit.ovirt.org/59649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to