Petr Horáček has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks ......................................................................
Patch Set 8: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/59645/7/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py: PS7, Line 65: target_vm_nets_by_mac it does not list vm_nets (bridges) by their mac but by macs of their ports, right? PS7, Line 65: target_vm_nets_by_mac = {dev['macAddr']: dev['network'] : for dev in target_vm_conf['devices'] : if dev['type'] == 'interface'} : : for interface in devices.findall('interface'): : if interface.get('type') == 'bridge': : _bind_iface_to_bridge(interface, target_vm_nets_by_mac) can you move this to another function with descriptive name? PS7, Line 149: if vm_id else () this is confusing. should we expect that uuid will be None? do we want to list all vms and handle only the first one? -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
