Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 383: self._vmid = vmid Line 384: self._irs = irs Line 385: self._prepared_volumes = [] Line 386: self._passwd_file = os.path.join(_V2V_DIR, "%s.tmp" % vmid) Line 387: self._base_command = [_VIRT_V2V.cmd, '-v', '-x'] > +1, how hard is to optionally add those? There is no reason not to. Any performance penalty caused by traces is negligible since most of the time of the import is spent on converting the disks. Do we have a way to run vdsm in debug mode? Or you mean to add a flag to UI? Either way it should be possible, but is it necessary? Bear in mind that converting the VM is a lengthy process that can potentialy take hours. In case of import failure this requires the user to enable debugging and rerun the import instead of just looking up the log. Line 388: Line 389: def execute(self): Line 390: raise NotImplementedError("Subclass must implement this") Line 391: Line 785: yield ImportProgress(int(current_disk), int(disk_count), Line 786: description) Line 787: for chunk in self._iter_progress(stream): Line 788: progress = self._parse_progress(chunk) Line 789: if progress is not None: > Maybe its verbose flag related? It's not unrelated. Se below. Line 790: yield DiskProgress(progress) Line 791: if progress == 100: Line 792: break Line 793: Line 811: Line 812: def _parse_progress(self, chunk): Line 813: m = self.DISK_PROGRESS_RE.match(chunk) Line 814: if m is None: Line 815: return None > unrelated? When verbose output is enabled there are other messages before the proggress. We don't want to throw an exception on those. Line 816: try: Line 817: return int(m.group(1)) Line 818: except ValueError: Line 819: raise OutputParserError('error parsing progress regex: %r' -- To view, visit https://gerrit.ovirt.org/59834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
