Dan Kenigsberg has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG Commit Message: Line 13: It would be cleaner to modify execCmd() to store the log output, but Line 14: this can dangerous without the function being refactored first. Line 15: Therefore we resort to a dirty hack with shell to redirect stderr to Line 16: stdout and store everything in a log file. This hack should be cleaned Line 17: once execCmd() is updated. I prefer this to be solved in the v2v tool or a helpr script that merges stdout and stderr. Alternatively, vdsm can watch both stdout and stderr in _watch_process_output. It can then funnel stdout to the OutputParser and stderr - to vdsm.log. Line 18: Line 19: Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e Line 20: Bug-Url: https://bugzilla.redhat.com/1350465 -- To view, visit https://gerrit.ovirt.org/59834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
