Nir Soffer has posted comments on this change. Change subject: verify_untrusted_volume: Check compatibility version ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/59411/6/lib/vdsm/storage/misc.py File lib/vdsm/storage/misc.py: Line 799: if qemu_format == qemuimg.FORMAT.QCOW2: Line 800: # Vdsm depends on qemu-img 2.3.0 or later which always reports 'compat' Line 801: # for qcow2 volumes. Line 802: compat = qemu_info["compat"] Line 803: if not qemuimg.supports_compat(compat): > For now we should use the 'qcow2_compat' config variable so that we only al No, most images that a user will upload are 1.1, and qemu supports such images for ages. We will accept these images, this check is correct. Line 804: raise se.ImageVerificationError( -- To view, visit https://gerrit.ovirt.org/59411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
