Amit Aviram has posted comments on this change. Change subject: verify_untrusted_volume: Check compatibility version ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/59411/7/lib/vdsm/storage/misc.py File lib/vdsm/storage/misc.py: PS7, Line 805: qcow2 With the current implementation of supports_compat(compat), this will check if VDSM generally supports the volume's compat level, while this specific host might not support it. we want this function to verify with "config.get('irs', 'qcow2_compat')" You can change supports_compat(compat) or add another helper that relies on this config. -- To view, visit https://gerrit.ovirt.org/59411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
