Petr Horáček has posted comments on this change. Change subject: ovs: add network with dhcp configuration ......................................................................
Patch Set 9: (6 comments) https://gerrit.ovirt.org/#/c/59039/8/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS8, Line 168: nets2remove: > It's not needed Done PS8, Line 192: address.IPv4(_ipv4_conf > The fun name has no real meaning. Done https://gerrit.ovirt.org/#/c/59039/8/tests/network/func_dhclient_test.py File tests/network/func_dhclient_test.py: PS8, Line 35: BITM > BITMASK Done PS8, Line 58: { > Is a newline necessary here? Done Line 65: NETWORK_NAME, netcreate[NETWORK_NAME]) Line 66: finally: Line 67: if bridged: Line 68: delete_dhclient_leases( Line 69: NETWORK_NAME, dhcpv4=True, dhcpv6=False) > Why is the cleanup needed? dhclient keeps leases for 2 minuts, we want to do every setup as a first one. i think it's needed, copied from functional/networkTests.py, i think osvoboda would know more. Line 70: else: Line 71: delete_dhclient_leases( Line 72: client, dhcpv4=True, dhcpv6=False) Line 73: https://gerrit.ovirt.org/#/c/59039/8/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 244: self.assertNotIn(bond, self.running_config.bonds) Line 245: Line 246: def assertNetworkIp(self, net, attrs): Line 247: if ('ipaddr' not in attrs and attrs.get('bootproto') != 'dhcp' and Line 248: 'ipv6addr' not in attrs): > For DHCP, you will exit here and it will be a false positive. Done, sorry about that. Line 249: return Line 250: Line 251: network_netinfo = self.netinfo.networks[net] Line 252: -- To view, visit https://gerrit.ovirt.org/59039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792713f27f41faf5e2ffffd4de02c51ad8d0ee02 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
