Petr Horáček has posted comments on this change. Change subject: ovs: add network with dhcp configuration ......................................................................
Patch Set 12: Verified+1 (3 comments) func_*_test.py passed OK https://gerrit.ovirt.org/#/c/59039/8/tests/network/func_dhclient_test.py File tests/network/func_dhclient_test.py: Line 65: Line 66: @attr(type='functional', switch='legacy') Line 67: class NetworkDhcpBasicLegacyTest(NetworkDhcpBasicTemplate): Line 68: __test__ = True Line 69: switch = 'legacy' > I'm not convinced, sounds like a leftover from the time we checked the leas Removed. Line 70: Line 71: Line 72: @attr(type='functional', switch='ovs') Line 73: class NetworkDhcpBasicOvsTest(NetworkDhcpBasicTemplate): https://gerrit.ovirt.org/#/c/59039/9/tests/network/func_dhclient_test.py File tests/network/func_dhclient_test.py: PS9, Line 35: > Not needed. bitmask is the mask in number of bits. PREFIX_LEN is the correct name. https://gerrit.ovirt.org/#/c/59039/9/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 243: self.update_running_config() Line 244: self.assertNotIn(bond, self.running_config.bonds) Line 245: Line 246: def assertNetworkIp(self, net, attrs): Line 247: if ('ipaddr' not in attrs and attrs.get('bootproto') != 'dhcp' and > You better also take care of dhcpv6 and ipv6autoconf as well here. Done Line 248: 'ipv6addr' not in attrs and 'dhcpv6' not in attrs and Line 249: 'ipv6autoconf' not in attrs): Line 250: return Line 251: -- To view, visit https://gerrit.ovirt.org/59039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792713f27f41faf5e2ffffd4de02c51ad8d0ee02 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
