Francesco Romani has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/57963/8//COMMIT_MSG Commit Message: Line 17: ... Line 18: dev_map[dev_type].append(dev_class(self.conf, self.log, **dev)) Line 19: Line 20: To avoid creating special case in the code, we replace HostDevice by Line 21: appropriate device class. this is convincing, but we can change vm.py as well, if needed :) Line 22: Line 23: Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
