Milan Zamazal has posted comments on this change. Change subject: hostdev: move usb device code to separate class ......................................................................
Patch Set 8: (1 comment) With the exception of the comment below it looks OK to me. https://gerrit.ovirt.org/#/c/57958/8/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 354: Line 355: return hostdev Line 356: Line 357: @classmethod Line 358: def update_device_info(cls, vm, device_conf, x): The same about the method name and `x' argument name as in the preceding patch. Line 359: alias = x.getElementsByTagName('alias')[0].getAttribute('name') Line 360: host_address = vmxml.device_address(x) Line 361: Line 362: # The routine is quite unusual because we cannot directly -- To view, visit https://gerrit.ovirt.org/57958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I481a966776089f37971a27637e06d21eafabd05c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
