Francesco Romani has posted comments on this change. Change subject: hostdev: move usb device code to separate class ......................................................................
Patch Set 8: Code-Review-1 (1 comment) -1 for visibility of the comments. https://gerrit.ovirt.org/#/c/57958/8/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS8, Line 314: self._deviceParams this seems a write-only attribute; if it isn't, please document where it is used. -- To view, visit https://gerrit.ovirt.org/57958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I481a966776089f37971a27637e06d21eafabd05c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
