Francesco Romani has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access ......................................................................
Patch Set 7: Code-Review+1 (1 comment) please reformat if you resubmit. https://gerrit.ovirt.org/#/c/58011/7/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS7, Line 119: return ({'unit': scsi_address['lun'], : 'bus': scsi_address['bus'], : 'target': scsi_address['target']}, pet peeve of mine: please reformat like return ({ 'unit': scsi_address['lun'], 'bus': scsi_address['bus'], 'target': scsi_address['target'], }, adapter) -- To view, visit https://gerrit.ovirt.org/58011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9983fd309869ebd8a4aacd8bfe42158cd26e64 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
