Martin Polednik has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/58011/7/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS7, Line 119: return ({'unit': scsi_address['lun'], : 'bus': scsi_address['bus'], : 'target': scsi_address['target']}, > pet peeve of mine: please reformat like That is mixing two indentations - not really doable. Anyway, in this particular case, I don't expect the dict to be changed - if kernel changes SCSI addressing, I give up. :) -- To view, visit https://gerrit.ovirt.org/58011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9983fd309869ebd8a4aacd8bfe42158cd26e64 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
