Yaniv Bronhaim has posted comments on this change.
Change subject: Make advanced process invocations part of execCmd
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File tests/miscTests.py
Line 1022: self.assertEquals(nice, 10)
Line 1023: proc.kill()
Line 1024: proc.wait()
Line 1025:
Line 1026:
What about testing all the options you added? ( ionice and setsid..)
Line 1027: class DeferableContextTests(TestCaseBase):
Line 1028: def setUp(self):
Line 1029: self._called = 0
Line 1030:
....................................................
File vdsm/storage/misc.py
Line 188:
Line 189:
Line 190: class NICENESS:
Line 191: NORMAL = 0
Line 192: LOW = 19
Don't you want to use the whole spectrum here.. you can add the niceset level
-20 and ioniceless 7.. why do you limit the options?
Line 193:
Line 194:
Line 195: @logskip("Storage.Misc.excCmd")
Line 196: def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
logErr=True,
--
To view, visit http://gerrit.ovirt.org/9042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5abd61c03ce907ea94761f0209a4626669051eb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
