Nir Soffer has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1516: "qcow2 compat %r is not supported" % compat) Line 1517: Line 1518: # Although we can handle both 0.1 and 1.1 compat qcow2 files, we Line 1519: # currently limit support to one or the other via the vdsm config. Line 1520: # Once both are supported concurrently this check can be removed. > I don't think we should add version cmp. It should be a set membership tes Regarding amend, it seems to be an option only for upgrading an image. Downgrading an image from 1.1 to 0.10 may require changes in actual image data and require more space (replacing empty clusters with reall zeros). I tested various images (rhel, fedora, centos, openstack), and all of them use the old 0.10 format. If we block this format by checking the current configuration, we practically break the image upload feature. If you want to add verification, it must not block upload of older version. Line 1521: required_compat = config.get('irs', 'qcow2_compat') Line 1522: if compat != required_compat: Line 1523: raise se.ImageVerificationError( Line 1524: "qcow2 compat %r is not supported by this host" % compat) -- To view, visit https://gerrit.ovirt.org/60113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
