Adam Litke has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config ......................................................................
Patch Set 4: Verified+1 (1 comment) Verified with unit tests. https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1516: "qcow2 compat %r is not supported" % qemu_compat) Line 1517: Line 1518: # Although we can handle both 0.1 and 1.1 compat qcow2 files, we Line 1519: # currently limit support to one or the other via the vdsm config. Line 1520: # Once both are supported concurrently this check can be removed. > Regarding amend, it seems to be an option only for upgrading an image. Down The default setting is to require '0.10'. For 4.0, 99% of users will be able to upload the most common images without issue. For users who have been early adopters of 1.1 (by changing host config files) they will have another step... Either manually amend before uploading, change a host back to '0.10', or wait until 4.1. I don't think we should make assumptions about the comparability of this compat string. Line 1521: required_compat = config.get('irs', 'qcow2_compat') Line 1522: if qemu_compat != required_compat: Line 1523: raise se.ImageVerificationError( Line 1524: "qcow2 compat %r not supported by this host" % qemu_compat) -- To view, visit https://gerrit.ovirt.org/60113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
