Dan Kenigsberg has posted comments on this change.
Change subject: Add an option to create a watchdog device.
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
Thanks!
Only a minor comment on excessive callback arguments.
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2208: # An enumeration of VM watchdog device types.
Line 2209: #
Line 2210: # @watchdog: Device type watchdog
Line 2211: #
Line 2212: # Since: 4.10.0
we're 4.10.1 already, not that anyone cares
Line 2213: ##
Line 2214: {'enum': 'VmWatchdogDeviceType', 'data': ['watchdog']}
Line 2215:
Line 2216: ##
....................................................
File vdsm/libvirtvm.py
Line 2200: self.startDisksStatsCollection()
Line 2201:
Line 2202: return {'status': doneCode}
Line 2203:
Line 2204: def _onWatchdogEvent(self, name, vmid, action):
why do we need name and vmid as args to this callback? aren't they already in
self.conf[vmId] and [vmName]?
ps. vmId is already logged by our SimpleLogAdapter.
Line 2205: def actionToString(action):
Line 2206: # the following action strings come from the comments of
Line 2207: # virDomainEventWatchdogAction in
include/libvirt/libvirt.h
Line 2208: # of libvirt source.
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
