Vinzenz Feenstra has posted comments on this change.
Change subject: Add an option to create a watchdog device.
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 2014: # of libvirt source.
Line 2015: actionStrings = ("No action, watchdog ignored",
Line 2016: "Guest CPUs are paused",
Line 2017: "Guest CPUs are reset",
Line 2018: "Guest is forcably powered off",
forcibly
Line 2019: "Guest is requested to gracefully
shutdown",
Line 2020: "No action, a debug message logged")
Line 2021: try:
Line 2022: return actionStrings[action]
Line 2423: address = self._getUnderlyingDeviceAddress(x)
Line 2424: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
Line 2425:
Line 2426: for dev in self._devices[vm.WATCHDOG_DEVICES]:
Line 2427: if not hasattr(dev, 'address'):
I would also check here for 'alias'
Line 2428: dev.address = address
Line 2429: dev.alias = alias
Line 2430:
Line 2431: for dev in self.conf['devices']:
Line 2429: dev.alias = alias
Line 2430:
Line 2431: for dev in self.conf['devices']:
Line 2432: if ((dev['type'] == vm.WATCHDOG_DEVICES) and
Line 2433: not dev.get('address')):
Same as line 2427
Line 2434: dev['address'] = address
Line 2435: dev['alias'] = alias
Line 2436:
Line 2437: def _getUnderlyingVideoDeviceInfo(self):
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
