Nir Soffer has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv ......................................................................
Patch Set 3: We have faling test: 20:56:03 ====================================================================== 20:56:03 ERROR: test_no_fakelvm (storagetestlibTests.FakeFileEnvTests) 20:56:03 ---------------------------------------------------------------------- 20:56:03 Traceback (most recent call last): 20:56:03 File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/storagetestlibTests.py", line 44, in test_no_fakelvm 20:56:03 self.assertIsNone(env.lvm) 20:56:03 AttributeError: 'FakeFileEnv' object has no attribute 'lvm' Looks like we need to change the test to test for attribute existence instead of None, or just remove this test. -- To view, visit https://gerrit.ovirt.org/60417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba0617c10e10005e706d9f2a7d4800f077e1c2b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
