Nir Soffer has submitted this change and it was merged. Change subject: tests: Add make_volume to FakeEnv ......................................................................
tests: Add make_volume to FakeEnv The storagetestlib module has fake_block_env and fake_file_env for creating fake environments and make_block_volume and make_file_volume for creating fake volumes within those fake environments. In order to simplify permutated tests that test both environment types, add a make_volume member to the FakeEnv object that can be called with the same parameters in the block and file cases. Change-Id: Ieba0617c10e10005e706d9f2a7d4800f077e1c2b Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/60417 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M tests/storagetestlib.py M tests/storagetestlibTests.py 2 files changed, 26 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieba0617c10e10005e706d9f2a7d4800f077e1c2b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
