Dan Kenigsberg has posted comments on this change. Change subject: storage.misc: subclass DeferableContext for easy undoing ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) -1 set for visibility. .................................................... File vdsm/storage/misc.py Line 732: class RollbackContext(DeferableContext): Line 733: ''' Line 734: A context manager for recording and playing rollback. Line 735: ''' Line 736: add = DeferableContext.prependDefer do we really need this alias? For me it is a distraction only. Line 737: Line 738: def __exit__(self, exc_type, exc_value, traceback): Line 739: firstException = exc_value Line 740: -- To view, visit http://gerrit.ovirt.org/8671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc932637dd81c3becf92de34ea647c1cea136111 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
