ShaoHe Feng has posted comments on this change. Change subject: storage.misc: subclass DeferableContext for easy undoing ......................................................................
Patch Set 4: (1 inline comment) .................................................... File tests/rollbackContextTests.py Line 62: self.tempfiles(10, UndoError, rollback) Line 63: Line 64: self.assertRaises(UndoError, exceptionInUndo) Line 65: # Directory and files should be removed Line 66: self.assertEquals(glob.glob(self.tmpdirPrefix + "*"), []) dirPath is better? Line 67: Line 68: def testExceptionUnderContext(self): Line 69: def exceptionUnderContext(): Line 70: with RollbackContext() as rollback: -- To view, visit http://gerrit.ovirt.org/8671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc932637dd81c3becf92de34ea647c1cea136111 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
