Alon Bar-Lev has posted comments on this change. Change subject: Implement SSL session cache ......................................................................
Patch Set 9: (1 inline comment) .................................................... File vdsm/SecureXMLRPCServer.py Line 66: # if it fails as we use the verify_fail_if_no_peer_cert mode. We Line 67: # are not doing any additional validation, so we just need to log Line 68: # it and return the same result. Line 69: if not result: Line 70: certificate = X509.X509(certificate) No need. Line 71: logging.error( Line 72: "invalid client certificate with subject \"%s\"", Line 73: certificate.get_subject()) Line 74: return result -- To view, visit http://gerrit.ovirt.org/8123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
