Juan Hernandez has posted comments on this change. Change subject: Implement SSL session cache ......................................................................
Patch Set 9: (1 inline comment) .................................................... File vdsm/SecureXMLRPCServer.py Line 101: # SSL connection: Line 102: return getattr(self.connection, name) Line 103: Line 104: Line 105: class SSLClientSocket(object): Lets look at it from this point of view: SSLServerSocket = a socket that the server uses to accept clients SSLClientSocket = a socket that the server uses to talk to the client The "server socket" shouldn't extend the "client socket" because a "server socket" is not "a socket that the server uses to talk to the client", so using inheritance for that is conceptually wrong, in my opinion. Line 106: """SSL decorator for client sockets. Line 107: Line 108: This class wraps a client socket returned by the accept method of a Line 109: server socket providing the SSL socket methods that are missing in -- To view, visit http://gerrit.ovirt.org/8123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
