Francesco Romani has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO ......................................................................
Patch Set 3: Code-Review-1 (1 comment) only one minor style comment https://gerrit.ovirt.org/#/c/60640/3/vdsm/virt/vm.py File vdsm/virt/vm.py: PS3, Line 1586: if not domxml.appendNumaTune(): this is one of the few cases on which we should use a temporary. We should really highlight that we do appendNumaTune(), and not """hide""" (yes I know "hide" is a too strong word here, but let's look at the concept :\) into a conditional. -- To view, visit https://gerrit.ovirt.org/60640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
