Dan Kenigsberg has posted comments on this change. Change subject: Implement SSL session cache ......................................................................
Patch Set 11: Looks good to me, approved (1 inline comment) so let's take this! .................................................... File tests/sslTests.py Line 124: Line 125: # Stop the server thread and wait for it to finish: Line 126: self.thread.shutdown() Line 127: self.thread.join() Line 128: del self.thread I must say that these del's make me raise an eyebrow. Line 129: Line 130: # Close the server socket: Line 131: self.server.shutdown(socket.SHUT_RDWR) Line 132: self.server.close() -- To view, visit http://gerrit.ovirt.org/8123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
