Shu Ming has posted comments on this change. Change subject: Adding support for force extend block domains ......................................................................
Patch Set 5: I really don't understand why we need the force flag here. It seems _initpvs() try to reinitialize the physical volume already in a volume group with new meta size. Is it meaningful to reinitialize a physical volume which is based on a physical device. And you can never extend a physical device because its size is hard limitted. Adding some comments to explain these may be helpful. -- To view, visit http://gerrit.ovirt.org/9192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
