Dan Kenigsberg has posted comments on this change. Change subject: Adding support for force extend block domains ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) any change to the API requires a compatible change to vdsm_api/vdsmapi-schema.json .................................................... File vdsm/storage/hsm.py Line 648: pool = self.getPool(spUUID) Line 649: pool.extendVolume(sdUUID, volumeUUID, size, isShuttingDown) Line 650: Line 651: @public Line 652: def extendStorageDomain(self, sdUUID, spUUID, devlist, force = False, options = None): too long line, breaks pep8. Line 653: """ Line 654: Extends a VG. ? Line 655: Line 656: .. note:: -- To view, visit http://gerrit.ovirt.org/9192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
