Mark Wu has posted comments on this change. Change subject: Logging: config logging in new process of remoteFileHandler ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/remoteFileHandler.py Line 36: Line 37: if __name__ == "__main__": Line 38: from logging import config as lconfig Line 39: loggerConfFile = constants.P_VDSM_CONF + 'logger.conf' Line 40: lconfig.fileConfig(loggerConfFile) I agree with ShaoHe on this one. I still can't see the benefit of not putting the code to line 385. Line 41: Line 42: import misc Line 43: import fileUtils Line 44: -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
