Zhou Zheng Sheng has posted comments on this change. Change subject: Logging: config logging in new process of remoteFileHandler ......................................................................
Patch Set 2: Verified (1 inline comment) .................................................... File vdsm/storage/remoteFileHandler.py Line 376: if __name__ == "__main__": Line 377: try: Line 378: from logging import config as lconfig Line 379: loggerConfFile = constants.P_VDSM_CONF + 'logger.conf' Line 380: lconfig.fileConfig(loggerConfFile, disable_existing_loggers=False) There is a reason for using disable_existing_loggers=False here. You can see the comments in the previous patch set. Should I add a comment here to explain why disable_existing_loggers=False? Line 381: Line 382: try: Line 383: myRead, myWrite = parseArgs() Line 384: closeFDs((myRead, myWrite, 2)) -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
